Skip to content

delete-root-analysis-artifact #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2017

Conversation

antgonza
Copy link
Member

No description provided.

@antgonza antgonza changed the base branch from master to dev August 18, 2017 11:00
@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #2244 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2244      +/-   ##
==========================================
+ Coverage   92.81%   92.82%   +0.01%     
==========================================
  Files         171      171              
  Lines       18905    18906       +1     
==========================================
+ Hits        17546    17549       +3     
+ Misses       1359     1357       -2
Impacted Files Coverage Δ
qiita_db/test/test_artifact.py 99.84% <100%> (ø) ⬆️
qiita_db/artifact.py 98.54% <100%> (ø) ⬆️
...t/handlers/api_proxy/tests/test_sample_template.py 98.66% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0a4b6...3e17876. Read the comment docs.

@josenavas
Copy link
Contributor

If I understand correctly, if the user deletes the last artifact there will be an empty analysis (i.e. no artifacts) so the user can delete it. Did you test how the interface behaves with this case? I'm unsure if it will just go smooth or it will fail somewhere else...

@antgonza
Copy link
Member Author

Yes, that's correct and it works fine ... I guess you didn't tested when you wrote it 😄

@josenavas josenavas merged commit a369cad into qiita-spots:dev Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants