Fix 1805 #2093
Merged
Fix 1805 #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
reviewed
Mar 27, 2017
qiita_pet/handlers/download.py
Outdated
| raise QiitaPetAuthorizationError( | ||
| self.current_user, 'filepath id %s' % str(fid)) | ||
| raise HTTPError( | ||
| 404, "%s doesn't have access to " |
|
I think if @wasade or someone else reviews we should be OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the missing documentation and fixing a link that we missed on previous reviews.
Previous PRs: #2087 & #2062.
@josenavas & @wasade, wanna do another review?
BTW, the new link is shown as:
and the documentations looks like: