Fix 1783: display EBI values #1804
Conversation
|
👍 |
| There are <b>{{num_samples}}</b> samples and <b>{{num_columns}}</b> columns in this preparation. | ||
| There are <b>{{num_samples}}</b> samples and <b>{{num_columns}}</b> columns in this preparation.</br> | ||
| {% if ebi_experiment_accessions %} | ||
| <b>EBI status: </b> Submitted |
There was a problem hiding this comment.
We have other statuses available right? Any reason why we are not showing the current status instead of just Submitted?
There was a problem hiding this comment.
Not really, this is for preps. This is, the study is what's being submitted/updated and the prep is only submitted/not-submitted and we know is submitted if the samples have ebi_experiment_accessions.
There was a problem hiding this comment.
Got it.
On (Apr-20-16| 9:36), Antonio Gonzalez wrote:
@@ -353,7 +353,10 @@
- There are {{num_samples}} samples and {{num_columns}} columns in this preparation. - There are {{num_samples}} samples and {{num_columns}} columns in this preparation.
- {% if ebi_experiment_accessions %} - EBI status: SubmittedNot really, this is for preps. This is, the study is what's being submitted/updated and the prep is only submitted/not-submitted and we know is submitted if the samples have ebi_experiment_accessions.
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/1804/files/854af66518166469335927275d9319f9a7ef5a1e#r60443512
|
This looks fine 👍 |
4 participants
This adds to the study page the EBI status and links once it's successful and also adds the status of the preps. After discussing with @ackermag we agreed that for the preps displaying a message was enough => not displaying all the accessions.