Fixing QiitaClient #1795
Merged
Fixing QiitaClient #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2016
Merged
…fix-rest-api-qiita-client
| # ----------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| class QiitaClientError(Exception): |
There was a problem hiding this comment.
They're used in the Qiita client and I think there are 3 different errors that the developer using the QiitaClient can decide what to do (either propagate the error or try something else). For example, this allows me to code a different behavior in the _heartbeat function below.
|
One question, then 👍 when test pass. |
|
@ElDeveloper available for a quick review in here? |
| # This error occurs when the Qiita server is not reachable. This | ||
| # may occur when we are updating the server, and we don't want | ||
| # the job to fail. In this case, we wait for 5 min and try again | ||
| time.sleep(300) |
There was a problem hiding this comment.
Would it be worth mentioning this in the docstring?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1794 so review/merge that one first.
The QiitaClient is improved to reduce workload on the plugin developer.