Test patch calls #1760
Merged
Test patch calls #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiita_pet/test/test_prep_template.py
Outdated
| self.assertEqual(response.code, 200) | ||
| exp = {'status': 'success', 'message': ''} | ||
| self.assertEqual(loads(response.body), exp) | ||
| pass |
|
1 small comment 👍 |
|
Comment addressed, ready to go. |
|
@squirrelo, could you confirm that your changes are OK with the new portal changes? Thanks. |
|
Shouldn't have any issues since this just touches test code, but pulled in master and restarted tests to make sure. |
|
Thanks, will merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1682 to properly make patch calls for tests.
data is now required, as without it the following is thrown and returned as part of the request:
ValueError('Body must not be None for method PATCH (unless allow_nonstandard_methods is true)