Share studies in studies #1755
Merged
Share studies in studies #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelo
force-pushed
the
share-studies-in-studies
branch
from
8af0017 to
38d1bb2
Compare
|
👍 when tests pass. @ElDeveloper could you take a look? |
Closed
qiita_pet/static/js/sharing.js
Outdated
| }, | ||
| minimumInputLength: 1, | ||
| formatResult: function (data, term) { | ||
| console.log(data); |
There was a problem hiding this comment.
Can you remove this line?
|
Cool, just a few comments! BTW, my system has no users and I don't have an email server setup ... @antgonza or @squirrelo anyway to test this somewhere? |
|
Comments addressed. I've been testing with the users supplied in the test database if you want to test on your system as well. No email server is needed for this PR. |
|
Tested with new users in my local machine and works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1730 and #1092
This adds the ability to share studies from the actual study page, as well as fixing the issue of showing all emails in the HTML of the page. Now the autocomplete is done using AJAX and the select2 javascript library.
The share modal looks and acts the same
