Fix user verify

[josenavas]

No description provided.

[coveralls]

Coverage increased (+0.03%) to 82.838% when pulling 6b5a69a on josenavas:fix-user-verify into 5345a85 on biocore:master.

[squirrelo]

This needs to be put in test_create to make sure this test is still done.

[antgonza]

Agree and more importantly we need to make sure the pathological case doesn't happens. I have created: #1731

[squirrelo]

General question: Why move this one piece from verify to create? It was originally in verify because a user can't log in until they are verified, so we saved extra message rows for users that sat unverified. Also, any messages that expire before a user verifies shouldn't matter since they expired before the user can log in and see them.

[antgonza]

@squirrelo the original code has a pathological case: if a user registers, then messages get added, and the user tries to verify their email, the system will fail cause the messages have already been added:

ValueError: Error running SQL query:
Query: INSERT INTO qiita.message_user (email, message_id)
                             SELECT %s, message_id FROM qiita.message
                             WHERE expiration > %s
Arguments: ['my_email@email.com', datetime.datetime(2016, 3, 31, 4, 49, 43, 242531)]
Error: duplicate key value violates unique constraint "idx_message_user"
DETAIL:  Key (email, message_id)=(my_email@email.com, 16) already exists.

[antgonza]

Closing in favor of: #1731