Offload template processing from webserver #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into artifact-study-pages-offload-templates
| alert_type = '' | ||
| alert_msg = '' | ||
|
|
||
| alert_msg = alert_msg.replace('\n', '</br>') |
There was a problem hiding this comment.
Do we really need this? Perhaps it will make more sense to have it in line 143.
|
A few comments. |
qiita_ware/context.py
Outdated
| acceptable, so this wrapper makes sure that the job_id | ||
| is returned only once the job has already been submitted. | ||
| From previous tests, the while loop is executed ~2 times, so there is no |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offloads the sample template create/update/delete and the prep template udpate from the webserver. The create/delete prep template are a bit more tricky given that those operations perform bigger changes in the interface, so I open an issue to keep track of it: #1719
Some of the fun stuff that starts happening here. The system becomes now way more distributed, as some of the processing is happening through moi and the interface is just checking it is done or not. It becomes really interesting at the time of testing the handlers, since they just submit and return right away, which means that we can't reset the DB at this point until the process running the job is done. Thus, I needed to put some waiting code on those tests.
In order to make the interface more responsive to this changes, we will need to introduce websockets, but I don't think it is blocking ATM.