adding tgz #1718
adding tgz #1718
Conversation
|
This is ready for review. It adds the possibility of downloading all files from an analysis and the failures from close-ref-picking via a new filepath_type = tgz. |
| _, base_fp = qdb.util.get_mountpoint(self._table)[0] | ||
| return join(base_fp, mapping_fp[0][0]) | ||
|
|
||
| @property |
There was a problem hiding this comment.
Can you use the function retrieve_filepaths from here ? This way it will look up the mountpoint correctly. This will fail, for example, in the test environment.
|
Few comments - plus still errors |
|
|
||
| tgz = to_tgz + '.tgz' | ||
| if not exists(tgz): | ||
| cmd = 'tar zcf %s %s' % (tgz, to_tgz) |
There was a problem hiding this comment.
Is there any benefit to use a subprocess instead of the tarfile module?
There was a problem hiding this comment.
I don't think so ... perhaps not loading into memory the files and let the system deal with that?
There was a problem hiding this comment.
Is that a known issue? It just seems unnecessary to use a subprocess, since there's already a module to do this.
There was a problem hiding this comment.
No that I know of ... changing.
|
Looks good, just two comments. |
|
👍 |
4 participants
No description provided.