Import artifact #1716
Merged
Import artifact #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into artifact-study-pages-import-artifact
…udy-pages-import-artifact
… into artifact-study-pages-import-artifact
| Name to give the artifact | ||
| prep_template_id : int or str castable to int | ||
| Prep template to attach the artifact to | ||
| artifact_id : str, optional |
There was a problem hiding this comment.
Is this really a str vs an int?
There was a problem hiding this comment.
This comes from the handler so it actually comes as a string.
There was a problem hiding this comment.
OK but note that prep_template_id also does and it can be int or str.
|
Looks good, just a few non-blocking comments, and fyi the tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables importing an artifact from another study that the user owns.