Assert items bug #1714
Merged
Assert items bug #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 6be4450 on josenavas:artifact-study-pages-assert-items-equal-bug into * on biocore:artifact-study-pages*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertItemsEqualcan't be used on dictionaries, it only tests the keys. I've done a search in the code base and fixed all the cases in whichassertItemsEqualwas incorrectly used.@antgonza it will be good to let this one to run the tests - and I have a problem fixing an instance in
qiita_db/test/test_analysis.pyso let me know when you're online and we can chat about it.