Skip to content

Conversation

@josenavas
Copy link
Contributor

This PR adds the property html_summary_fp to the artifact. It also adds the method "patch" to the ArtifactFilepathsHandler so plugins can add the HTML summary to the artifacts.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 82.849% when pulling 7d2b4c8 on josenavas:artifact-study-pages-patch-filepaths into 78c7ea0 on biocore:artifact-study-pages.


self.write(response)

@authenticate_oauth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed comment below.

@ElDeveloper
Copy link
Contributor

👍

@antgonza
Copy link
Member

Thanks @ElDeveloper and @josenavas. Merging as the changes will not change the tests.

antgonza added a commit that referenced this pull request Mar 21, 2016
…lepaths

Add HTML summary to the artifacts
@antgonza antgonza merged commit 2f6fa27 into qiita-spots:artifact-study-pages Mar 21, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 82.849% when pulling 7b19ea9 on josenavas:artifact-study-pages-patch-filepaths into 78c7ea0 on biocore:artifact-study-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants