Reduce tests running time for qiita_db #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's interesting, reducing the running time of the tests in my machine by ~4 min is equivalent to ~30 min in Travis? Wow - I saw that there are a couple of failures, I'm gonna fix them here. |
|
I can confirm this behavior from my other improving-tests tests. However, I can't explain why. |
… warning and the stochacity of the order in which the tests are executed
… into artifact-study-pages-tests-reduce-qiita-db
|
This is ready for review. The main changes here are splitting the tests between read-only and read-write. I've also fixed the last 3 tests that were failing, which where mainly due to the usage of sets which makes the output order undefined. |
|
👍 |
1 similar comment
|
👍 |
ElDeveloper
added a commit
that referenced
this pull request
Feb 28, 2016
…duce-qiita-db Reduce tests running time for qiita_db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of: #1647 so review/merge that one first.
Here I split the tests of processing job, software and artifact between read/write and read/only, as well as grouping tests that are testing the same thing. This reduces the amount of times the database needs to be reset. Times: