Fix metadata file retrieval #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadata-file-retrieval
|
👍 |
qiita_db/util.py
Outdated
| The object id | ||
| sort : {'ascendent', 'descendent'}, optional | ||
| The direction in which the results are sorted, using the filepath id | ||
| as sorting key. Default: None, no sorting is applyed |
|
Few comments. 👍 once they are addressed |
|
No comments outside @mortonjt already commented on. 👍 when fixed. |
|
Thanks for the reviews! Comments addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the test environment a found a bug on how the sample template files are being retrieved. This PR fixes the issue by re-using the function in util and removing a lot of duplicated code :D