Workflow object #1641
Merged
Workflow object #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiita_db/handlers/processing_job.py
Outdated
| payload_success = payload['success'] | ||
| if payload_success: | ||
| artifacts = payload['artifacts'] | ||
| error = None |
There was a problem hiding this comment.
Should error be '' so we always return a string?
There was a problem hiding this comment.
Ignore this, got confused with error_msg. However, error_msg will not be defined, right?
There was a problem hiding this comment.
error_msg is defined in line 171.
|
A few comments. |
… into workflow-object
| edges = [(nodes[s], nodes[d]) for s, d in edges] | ||
| g.add_edges_from(edges) | ||
| else: | ||
| # It is possible that there are no edges because we are still |
There was a problem hiding this comment.
One of this is missing a test.
|
A few more comments. |
|
@ElDeveloper and/or @mortonjt can you review this PR? |
… into workflow-object
… into workflow-object
| processing_parameters=params) | ||
| job.status = 'success' | ||
| payload = loads(self.request.body) | ||
| try: |
There was a problem hiding this comment.
Would you mind restricting the scope of this try block to just the line that might raise the exception?
|
👍 |
|
Thanks! Comments addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary DB structure to support default workflows from plugins and user-generated workflows.
Overview of changes in this PR: