Plugin qiita-pet #1552
Merged
Plugin qiita-pet #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If information can't be NULL there should be an error somewhere (either the interface is assuming that is always there, or either the database should have a NOT NULL restriction and update the python code accordingly).
There was a problem hiding this comment.
This shouldn't be blocking so I added an issue: #1553
|
Couple of comments, otherwise 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes qiita-pet with artifacts. The changes are minimal but had to create a new method to return the pmid ids from the doi. Additionally, I realized that I had to change the populate so the log display works. The next things to do are fix the 'TODO plugin' sections and make sure that jobs work: split libs, analysis, etc.