WIP: Fixing EBI code #1540
Merged
WIP: Fixing EBI code #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-general-fixes
…in-general-fixes
qiita_ware/ebi.py
Outdated
There was a problem hiding this comment.
After discussing offline with @josenavas we agreed that this is a redundant verification as can_be_submitted_to_ebi is set to False for those cases where prep_template>1 during creation.
|
One comment, then 👍 |
qiita_db/artifact.py
Outdated
qiita_ware/test/test_ebi.py
Outdated
There was a problem hiding this comment.
Would it be worthwhile to add a comment on where this magic number comes from?
|
A few anal comments. Otherwise looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1537 so review/merge that one first
This fixes the EBI code so we can do some testing with the plugin system (right now we can't even start the webserver)