Fix study and analysis objects/tests #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fact-fix-study-and-analysis
|
@josenavas, when you have a chance can you pull from |
|
@ElDeveloper you should review/merge #1529 first. |
…fact-fix-study-and-analysis
qiita_db/analysis.py
Outdated
There was a problem hiding this comment.
I know you didn't change this but are the black lines necessary? In the past we have use - at the beginning of each paragraph. Obviously, not blocking.
|
👍 looks good to me! |
antgonza
added a commit
that referenced
this pull request
Nov 17, 2015
Fix study and analysis objects/tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on #1529 so review/merge that one first.
Fixes the tests for the study and analysis objects. It also fixes the objects to retrieve instances of other objects rather than just the id.