cover some of the issue in the joy list #1467
Conversation
qiita_ware/ebi.py
Outdated
There was a problem hiding this comment.
Dumb question. What exactly is Element? Is it an xml element corresponding to xml.etree? It would be nice to include the object type in the docs
There was a problem hiding this comment.
I can do that but AFAIK is not standard (however, this is not a standard type). What about xml.etree.ElementTree.Element?
There was a problem hiding this comment.
Actually, we commonly use pd.DataFrame instead of pandas.DataFrame or np.DataFrame instead of numpy.DataFrame.
So just ET.Element should be good enough.
There was a problem hiding this comment.
The reason we use np and pd instead of numpy and pandas is because np and pd are standard abbreviations. Is ET a standard abbreviation of xml.etree.ElementTree?
There was a problem hiding this comment.
It seems to be: https://docs.python.org/2/library/xml.etree.elementtree.html
There was a problem hiding this comment.
Thanks for checking! In such case, 👍 to ET.Element
|
Thanks @antgonza, done with the review. |
|
👍 |
cover some of the issue in the joy list
4 participants
As discussed yesterday, this PR is solving some of the standing issues in the PR #1451. This should be easy and quick to review.