Skip to content

Conversation

@josenavas
Copy link
Contributor

in a clean environment, the sphinx-bootstrap-theme doesn't get installed and it is required in order to build the documentation, which is one of the steps of qiita pet webserver start

@antgonza
Copy link
Member

👍 if tests pass.

setup.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move Sphinx to the install_requires section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, once tests pass this is ready for merge!

On (Aug-24-15|15:57), Jose Navas wrote:

@@ -91,13 +91,14 @@
]},
scripts=glob('scripts/*'),
extras_require={'test': ["nose >= 0.10.1", "pep8", 'mock'],

  •                  'doc': ["Sphinx >= 1.2.2", "sphinx-bootstrap-theme"]},
    
  •                  'doc': ["Sphinx >= 1.2.2"]},
    

Done


Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/1438/files#r37815230

@josenavas
Copy link
Contributor Author

@ElDeveloper tests are passing!

ElDeveloper added a commit that referenced this pull request Aug 24, 2015
bootstrap theme is required for building the help page
@ElDeveloper ElDeveloper merged commit a03564a into qiita-spots:master Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants