BUG: Fix bug in moi.init #1123
Merged
BUG: Fix bug in moi.init #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The position of the group_id argument was moved and the rest of the code was not updated to reflect this. This change set moves group_id so it is the first argument.
|
This problem would cause the analysis waiting page to be blank. |
|
I'd say to open a PR upstream, but I know your take on moi... |
|
@wasade, I went over there first, but I saw this: https://github.com/biocore/mustached-octo-ironman/pull/19/files ... I've added a note in the code 🍺 |
|
Tests are passing but it seems like coveralls has choked, anyone wants to have a look? This is blocking for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position of the group_id argument was moved and the rest of the code
was not updated to reflect this. This change set moves group_id so it is
the first argument.