Skip to content

ENH: Meta Analysis -> Analysis #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2015
Merged

Conversation

ElDeveloper
Copy link
Contributor

Users have frequently pointed out that naming this tab as "Meta
Analysis" is misleading and that a better name would be simply Analysis.

Users have frequently pointed out that naming this tab as "Meta
Analysis" is misleading and that a better name would be simply Analysis.
@josenavas
Copy link
Contributor

👍 I did not test locally but I will be very surprised if this broke something...

@antgonza
Copy link
Member

I think you should replace all cases of metaanalyss ...

@ElDeveloper
Copy link
Contributor Author

@antgonza, sounds good will do.

I also just noticed that we have two ways of getting to the "selected samples page" (through the selected button on the far right and through the "view selected samples" under the Analysis drop down menu). What do you guys think about:

  • Remove the selected button on the far right.
  • Add another option to the dropdown menu "create from selected samples", that brings up the form that lets you enter an analysis name.

Note these changes are not necessary and there are other things that are higher priority ... but I'm putting this out there just in case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.43% when pulling dbf7ad5 on ElDeveloper:minor-wording into 09bd0f7 on biocore:master.

@ElDeveloper
Copy link
Contributor Author

@antgonza, I was surprised to find this but that's the only occurrence:

yoshikivazquezbaeza:qiita@master$ grep -ri 'meta analysis' qiita_pet
qiita_pet/templates/sitebase.html:              <a href="#" data-toggle="dropdown" class="dropdown-toggle">Meta Analysis<b class="caret"></b></a>
yoshikivazquezbaeza:qiita@master$ grep -ri 'metaanalysis' qiita_pet
yoshikivazquezbaeza:qiita@master$ grep -ri 'metaanalysis' qiita_db/
yoshikivazquezbaeza:qiita@master$ grep -ri 'metaanalysis' qiita_ware/
yoshikivazquezbaeza:qiita@master$ grep -ri 'meta analysis' qiita_db/
yoshikivazquezbaeza:qiita@master$ grep -ri 'meta analysis' qiita_ware/

@antgonza
Copy link
Member

Try:
grep -iR 'meta.analy' ./

@ElDeveloper
Copy link
Contributor Author

Thanks, that helped. Pushed.

On (Apr-27-15|16:51), Antonio Gonzalez wrote:

Try:
grep -iR 'meta.analy' ./


Reply to this email directly or view it on GitHub:
#1112 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.43% when pulling af5423c on ElDeveloper:minor-wording into 09bd0f7 on biocore:master.

@antgonza
Copy link
Member

👍 @josenavas could you give it another pass?

josenavas added a commit that referenced this pull request Apr 28, 2015
@josenavas josenavas merged commit 33e5404 into qiita-spots:master Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants