Fix analysis tests #1106
Merged
Fix analysis tests #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
just pushed from upstream |
|
Thanks @josenavas, I'm gonna start reviewing right now. @squirrelo, quick reminder that you should also review this one. |
|
|
||
| # write mapping file out | ||
| if len(samples) != len(set(samples)): | ||
| duplicates = [s for s in samples if samples.count(s) > 1] |
There was a problem hiding this comment.
You can use find_duplicates here: http://scikit-bio.org/docs/latest/generated/skbio.util.find_duplicates.html?highlight=duplicates#skbio.util.find_duplicates
|
@josenavas, this looks in really good shape. |
|
Good to go after @ElDeveloper comments addressed. |
|
Ready for another round! |
|
Thanks @josenavas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1099
The test database was incomplete. We were missing the prep template file and the qiime mapping file for the prep template that was already in the database. I've added those and I fixed the tests for the analysis object.
After this PR, all tests in the qiita_db folder should be passing. However, there will be still some errors on qiita_ware, which I will fix in another PR.