Skip to content

delete sample template #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2015
Merged

delete sample template #1059

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e3a802
delete sample template
antgonza Apr 13, 2015
e9d3345
addressing @squirrelo comments
antgonza Apr 13, 2015
4e6099a
adding tests
antgonza Apr 13, 2015
e2a5558
Merge branch 'master' of https://github.com/biocore/qiita into delete…
antgonza Apr 15, 2015
62e1aff
adding tests to qiita pet
antgonza Apr 15, 2015
b47cbd5
fixing flake8 error
antgonza Apr 15, 2015
1a6762d
addressing @josenavas comment
antgonza Apr 15, 2015
a87fc2f
addressing @josenavas gui comment
antgonza Apr 15, 2015
3a76380
fixing flake8
antgonza Apr 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixing flake8
  • Loading branch information
@antgonza
antgonza committed Apr 15, 2015
commit 3a76380948e2f5016f5e8505892a53385335fc1b
2 changes: 1 addition & 1 deletion qiita_pet/test/test_study_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ class TestEBISubmitHandler(TestHandlerBase):

class TestDelete(TestHandlerBase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this tests should include database = True; since they can potentially modify the database, in case of malfunction; making a lot of tests to fail and harder to find the original problem.

database = True

def test_delete_sample_template(self):
response = self.post('/study/description/1',
{'sample_template_id': 1,
Expand Down