Skip to content

Removing add_category function #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2015
Merged

Removing add_category function #1055

merged 2 commits into from
Apr 10, 2015

Conversation

josenavas
Copy link
Contributor

Reasons for it's removal:

  • It is not used anywhere in the code base
  • It has a bug, it is not modifying the study_columns table.
  • It is repetitive. The same functionality can be accomplished with the extend function.

@josenavas josenavas added this to the Alpha 0.1 milestone Apr 9, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9c80092 on josenavas:remove-add-category into * on biocore:master*.

@ElDeveloper
Copy link
Contributor

:+

@ElDeveloper
Copy link
Contributor

1:

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 79.03% when pulling 9c80092 on josenavas:remove-add-category into 3ad2264 on biocore:master.

antgonza added a commit that referenced this pull request Apr 10, 2015
@antgonza
Merge pull request #1055 from josenavas/remove-add-category
3aa8f73 
Removing add_category function
@antgonza antgonza merged commit 3aa8f73 into qiita-spots:master Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug enhancement priority: high refactor
Projects
None yet
Milestone
Alpha 0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@josenavas @coveralls @ElDeveloper @antgonza