Solve stochastic failure #1046
Merged
Solve stochastic failure #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @biocore/qiita-dev |
|
👍 |
| @@ -561,7 +561,7 @@ def _add_common_creation_steps_to_queue(cls, md_template, obj_id, | |||
| values, many=True) | |||
|
|
|||
| # Insert rows on *_columns table | |||
| headers = list(set(headers).difference(db_cols)) | |||
| headers = sorted(list(set(headers).difference(db_cols))) | |||
There was a problem hiding this comment.
Minor, but the cast to a list is not needed here:
>>> x = {1, 1, 1, 1, 1, 3, 5555, 4, 5}
>>> sorted(x)
[1, 3, 4, 5, 5555]There was a problem hiding this comment.
I did not know that! Thanks!
There was a problem hiding this comment.
👍
On (Apr-08-15|10:07), josenavas wrote:
@@ -561,7 +561,7 @@ def _add_common_creation_steps_to_queue(cls, md_template, obj_id,
values, many=True)# Insert rows on *_columns table
headers = list(set(headers).difference(db_cols))headers = sorted(list(set(headers).difference(db_cols)))I did not know that! Thanks!
Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/1046/files#r27990502
|
👍 just one minor comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a potential stochastic failure in the metadata template tests. It is solved by enforcing some sorting on the way the columns are inserted in the database, so it is easy testable.
I would appreciate a fast review on this one as it can potentially impact any future PR.