Cart analysis changes #1038
Merged
Cart analysis changes #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalysis-changes
…nalysis-changes
|
Changes Unknown when pulling ba42c6a on squirrelo:cart-analysis-changes into * on biocore:cart-branch*. |
|
changed to new branch and ready for review |
This was referenced Apr 6, 2015
|
ping @biocore/qiita-dev this needs review before I move forward on anything else. |
| JOIN qiita.reference USING (reference_id) | ||
| WHERE processed_params_id = {1} | ||
| """.format(static_info['processed_params_table'], | ||
| static_info['processed_params_id']) |
There was a problem hiding this comment.
Can these 2 sql be a single left (or right) join?
There was a problem hiding this comment.
No, since it is dynamic table info so we need the table name and row from the first to do the second query.
There was a problem hiding this comment.
OK, I think your method is way simpler even if it requires 2 queries.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates the carts for each user and the cart viewing page. Major pieces are:
Analysis.get_user_default(User)function added to get the default analysis for a userprocessed_data.processing_infoadded to get processing information needed for cart display.This is the final piece needed before tying everything together from the last few pull requests into a single unified sample selection system.
This is also the first test of the separate branch for large changes system. This will be working on biocore/cart-branch and then merged in when finished.