Add columns during edit #1016
Closed
Add columns during edit #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@squirrelo besides the problems connecting to the redis server, it looks like there is a legitimate test failure! |
|
Seems like only redis failures now. |
|
ready for review |
| if default is not None: | ||
| # mogrify the sql and add to end | ||
| with conn_handler.get_postgres_cursor() as cur: | ||
| sql = sql + cur.mogrify(" NOT NULL DEFAULT %s", [default]) |
There was a problem hiding this comment.
Check the comment of the first answer on this thread. In short, mogrify should be used only for debugging, not for generating code. Anyways, I also find this solution more convoluted, so if you can just add the if and generate either of the sql in the specific case of the if would be more cleaner/maintainable.
|
Closing in favor of #1021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is needed for EBI submission, this should get reviewed and merged quickly.
This allows addition of columns during editing of a sample template. It also cleans up the add and remove category functions, as they were missing the addition of the column names to the study_sample_columns table.