-
Notifications
You must be signed in to change notification settings - Fork 80
DataTables load using AJAX, Search by metadata on studies page #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SciPy build is failing, causing the tests to register as failed. Not sure what to do.
|
Changes Unknown when pulling 1872555 on squirrelo:cart into * on biocore:master*. |
@@ -176,6 +182,28 @@ def get_by_status(cls, status): | |||
return {x[0] for x in conn_handler.execute_fetchall(sql, (status, ))} | |||
|
|||
@classmethod | |||
def get_info(cls, study_ids, info_cols=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This is failing because of qiime install issues, but is ready for review. |
Since I've already faced 2 database merge conflicts on my previous PR #900 please, review that one and merge that one first... |
Single list for now, Issue #1019 opened for later multi-table support. |
Thanks @squirrelo, baby steps works, so PR are smaller. Assigned to you and to alpha. |
BTW, this PR is not modifying the DB schema files neither the html. See this section on the contributing.md file for making database changes. |
Ready for review/merge |
Some comments on code. The GUI looks soooo much better, thanks! Anyway, when I try to search the button gets grayed out but nothing happens, not even python or JS errors, and never comes back. Also, not sure what the left checkbox column is for, there is no button to add or anything like that. |
Checkbox is a placeholder for sample selection, which will be added once all the initial bits are in place. Doesn't harm anything, and means there is less to change to get full functionality. I'll take a look at the JS, sounds like browser compatibility issue. |
What about adding the button(s) that will interact with the studies selected but when you click them you get a simple message like: "Not yet implemented" so we can review the distribution of the GUI. BTW I'm using Chrome Version 41.0.2272.104 (64-bit) |
I'd rather wait and add the button when it works, that way we don't ever give the impression of being able to select studies on the page until you actually can. I don't want to confuse users. |
Also, if all goes well, there won't be a button. It will ajax-select the samples as the things rea clicked and unclicked. |
That will be nice but note that having the checkboxes already gives
the wrong impression. What about removing or commenting that section
in the code so they do not get created and mislead users? Other option
is to have that functionality part of this PR but I can see the
benefits of having this already deployed.
|
I guess I can comment out the code and just return a blank line for those cells. |
Thanks, that works for me.
|
Changes made, ready for merge. |
Thanks. Tested and works fine except that if I search for the example:
env_matter includes soil AND (ph < 4 OR ph > 8) I get no results but
if I go to the metaanalysis page and do the same search I get results,
any ideas?
|
Just tested and I get the same results on both pages. Not sure how you're getting no results as it's all the same search object setup. |
Thanks for checking. Figured it out, when you search the "Narrow
search results by column data (Title, abstract, PI, etc):" field
doesn't get cleaned so it seems that there are no results but there
are ... could you clean on click?
|
The checkboxes are too embedded in the code to safely hide them and re-add later. The textbox is cleared on search now though. |
DataTables load using AJAX, Search by metadata on studies page
This pull request lays the groundwork for selections by study on the study listing page. The following changes have happened: