-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ML backends to Qiboml #1365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
- Coverage 99.84% 99.82% -0.02%
==========================================
Files 74 72 -2
Lines 10806 10507 -299
==========================================
- Hits 10789 10489 -300
- Misses 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BrunoLiegiBastonLiegi @Edoardo-Pedicillo now tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is fine, my only concern is whether it is better to specialize the backend loading for qiboml
as you are doing here, which allows not to brake all the previous code that was using set_backend("tensorflow")
, but creates an asymmetry with the other backend providers, such as qibojit
. Or, whether it is preferable to modify the qiboml
metabackend to have a platform argument selecting the actual backend out of the ones qiboml
provides, this would simplify this PR and maintain the symmetry with the other repos, but will involve setting the backends as set_backend("qiboml", platform="tensorflow")
. What do you think @alecandido ?
@BrunoLiegiBastonLiegi I'd just go for the uniform scheme, no need to make Qiboml different from the other providers. We should keep a single instruction, just for Moreover, I'd even drop all the |
Co-authored-by: BrunoLiegiBastonLiegi <45011234+BrunoLiegiBastonLiegi@users.noreply.github.com>
Checklist: