Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimating entangling power + poetry #22

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Estimating entangling power + poetry #22

merged 6 commits into from
Feb 28, 2024

Conversation

MatteoRobbiati
Copy link
Collaborator

@MatteoRobbiati MatteoRobbiati commented Feb 27, 2024

Two improvs:

  1. added pyproject.toml file and fix imports;
  2. added extras/ folder with a script to compute the entangling power of the VQE according to the Meyer-Wallach measure implemented here in Qibo. This values should be related to the BPs also. Entangling capability score is in $[0,1]$, with $0=$ no entangling capability 🐔, $1=$ super entangling power 👾.

I tested the entangling capability of the model with the following configurations:
entangling_power

Copy link
Collaborator

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the computation of the entangling power.
I'm not sure about making this repository a package... if I it just for academic purposes we might have just a repository. Making it a package it would mean to put effort in maintaining and releasing the library.
What was your motivation behind adding poetry?

@MatteoRobbiati
Copy link
Collaborator Author

I don't think having a package ensures us to these future efforts. It just help us now with imports and, when publishing the paper, it will be useful to have a Zenodo page anyway :)

@andrea-pasquale
Copy link
Collaborator

Ok, if it is just to facilitate people to reproduce the paper results, fine. Making in it a "proper" package it is a different story.

@MatteoRobbiati
Copy link
Collaborator Author

Ok, if it is just to facilitate people to reproduce the paper results, fine. Making in it a "proper" package it is a different story.

Ah yes, of course that was not my idea. If you think this is an overkill fine with restoring the original shape!
I only wanted to exploit some minor utilities, not starting a "proper" package developement.

@andrea-pasquale
Copy link
Collaborator

Ah yes, of course that was not my idea. If you think this is an overkill fine with restoring the original shape!
I only wanted to exploit some minor utilities, not starting a "proper" package developement.

Just for the development I agree :)

Copy link
Collaborator

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice plot @MatteoRobbiati , @marekgluza do you know other metrics that we could include to evaluate if there is a BP ?

@marekgluza marekgluza merged commit 45cd7a3 into main Feb 28, 2024
@marekgluza
Copy link
Contributor

I don't know much about BPs but you might be able to evaluate something called 'frame potential' and that would check how 'chaotic' the circuit is, it's something people check to see if they typically have a t-design.

@Edoardo-Pedicillo Edoardo-Pedicillo deleted the entangling-power branch October 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants