Add an option to disable automatic zoom in routing plugin #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
manisandro
reviewed
Oct 4, 2024
plugins/Routing.jsx
Outdated
| @@ -60,6 +60,8 @@ class Routing extends React.Component { | |||
| initiallyDocked: PropTypes.bool, | |||
| side: PropTypes.string | |||
| }), | |||
| /** Automatic zoom to the extent of the location. */ | |||
There was a problem hiding this comment.
What about "Automatically zoom to the extent of the route"?
|
Should be good now |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @manisandro,
I would like to submit this PR to add an option in the routing plugin to disable automatic zoom.
In some use cases, it could be more convenient for the user to keep the map from adjusting to the calculated road extent. For example, if they want to add another point farther away or if they have other elements on the map and do not want the scale to change.
I will update the documentation accordingly if this is approved.
Please feel free to share any feedback.
Kind regards,
Clément