Fix 3D rubber band with globe (and large scenes) #61400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The individual 3D entities need QgsGeoTransform attached so they work well with origin changes. We also need to handle altitude clamping with geocentric coordinates differently, because the assumption that Z coordinates means altitude does not hold anymore. Full support is left as a TODO for future implementation (when dealing with vector layers in globe). Also, polygon entity of 3D rubber band will need improvements in tessellator, so that it can handle origin with non-zero Z coordinates - also left as a TODO for later when dealing with vector layers in globe.
for more information, see https://pre-commit.ci
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Apr 9, 2025
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
nyalldawson
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The individual 3D entities need QgsGeoTransform attached so they work well with origin changes.
We also need to handle altitude clamping with geocentric coordinates differently, because the assumption that Z coordinates means altitude does not hold anymore. Full support is left as a TODO for future implementation (when dealing with vector layers in globe).
Also, polygon entity of 3D rubber band will need improvements in tessellator, so that it can handle origin with non-zero Z coordinates - also left as a TODO for later when dealing with vector layers in globe.