Make plugin watchdog considering timestamp of last run. Fixes #59370 #59371
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borysiasty
added
Plugins
Bug
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
borysiasty
added
the
Squash!
nyalldawson
reviewed
Nov 7, 2024
| @@ -118,7 +118,8 @@ def __init__(self): | |||
| self.uninstallPlugin(key, quiet=True) | |||
| updateAvailablePlugins() | |||
| if plugin_is_active: | |||
| settings.setValue("/PythonPlugins/watchDog/" + key, True) | |||
| settings.setValue("/PythonPlugins/watchDog/" + key, | |||
There was a problem hiding this comment.
I think we should switch to a new key here -- I'm worried changing the value type for an existing key may cause issues if a profile is shared with older qgis versions...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you quickly run two QGIS instances one by one, it often wakes the plugin watchdog up: one instance sets the QgsSettings entry, and then the another sees it and thinks it's a crash leftover.
This PR contains a proposed solution: switching the settings entry from boolean value to timestamp. Entries older then 5 seconds are considered crash leftovers, while newer are considered to come from a parallel instance.
Backward compatibility is ensured:
true) are converted to integer1, thus are recognized as a very old timestamp.