Correctly delete graduated layout widgets #54943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
3D
troopa81
added
backport queued_ltr_backports
nyalldawson
approved these changes
Oct 16, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54549
The issue happens only on french (and german it seems) because of the sort order of graduated method. In french, fixed interval is the first one and adds a processing parameter in the layout before setting the actually renderer one.
When it occurs, the old widget was not immediately cleared and then lead to display it above the table.
@3nids I assume you used deleteLater because you wanted to delete the layout first and the widget then, or is there another specific reason?