[processing] Fix add (single) row tool button broken #39712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
Processing
|
This seems strange that the default argument is ignored to be honest. If this is the case, would it be better to emit 1 when the signal is sent or to add a new function to circumvent the issue? I'm just asking to see what would be best practice. |
|
It's actually not ignored, but set to false due to the clicked signal being connected as one checked parameter, which it passes onto nb. A if nb is False conditional check at the beginning of addRow could be an alternative approach, I just felt it was a bit more hackish. |
|
@nirvn Thank you for the info! I didn't know how qt handled those case. |
nirvn
force-pushed
the
batch_addrow_fix
branch
from
ac610c1
to
46c4b74
Compare
nyalldawson
approved these changes
Nov 1, 2020
|
(insert usual grumbles about fragility of Python code here!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39696.