Avoid long loading in attributetable on model change #36194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rFeatures slot instead of datachanged of model since this leaded to unneeded and long reloading after the main model is reloaded fixes qgis#35927
signedav
added
Backport
|
Backport PR for 3.10: #36354 |
|
Just tested and it's working ok! Thanks @signedav |
|
Perfect. Thanks a lot @tudorbarascu |
3nids
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal changeset to fix #35927 on the backport branches.
The connection from
dataChangedtoreloadVisibleandfilterFeaturesleaded to very long loading times. It's improved in this master PR #36188.This here replaces the signal for
reloadVisibleandfilterFeatureswithfeatureAddedof the vector layer. The implementation, that leaded to issues (connectingdataChanged) has been implemented for this case offeatureAdded. So this fix should still cover the requirement for this change.