Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Expression builder] show represented values in preview #10037

Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented May 20, 2019

Instead of only showing the raw values, show also the represented values in the expression builder in the list values preview.
This helps people to choose from readable values (whereas still the raw values get inserted on double click).

image

Should we ship this as a UX fix or wait for post 3.8? Kind of on the boarder between feature and bugfix

Instead of only showing the raw values, show also the represented values in the expression builder in the list values preview.
This helps people to choose from readable values (whereas still the raw values get inserted on double click).
@m-kuhn m-kuhn changed the title Expression builder: show represented values in preview [Expression builder] show represented values in preview May 20, 2019
@m-kuhn
Copy link
Member Author

m-kuhn commented May 21, 2019

@nyalldawson and anyone else, what's your opinion:

  • include in 3.8?
  • backport to 3.4?

I think it could be treated as a UX fix (merge to 3.8 now, wait for 1-2 weeks of field testing before merging the backport

@stale
Copy link

stale bot commented Jun 4, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 4, 2019
@luipir
Copy link
Contributor

luipir commented Jun 4, 2019

merge to 3.8 now, wait for 1-2 weeks of field testing before merging the backport

it's safe for me

@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 4, 2019
@m-kuhn m-kuhn merged commit b9d5cde into qgis:master Jun 4, 2019
@m-kuhn
Copy link
Member Author

m-kuhn commented Jun 4, 2019

I'll read this as an approval of this PR, thanks @luipir ;)

@m-kuhn m-kuhn deleted the expression_builder_show_represented_values branch June 4, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants