Adding Join while attribute table is open causes Qgis to hang

[Promethean-Roil]

What is the bug or the crash?

When you join to layers (via layer properties) if the attribute table of the destination layer is open (in the background, minimised etc) qgis will hang indefinitely.

Steps to reproduce the issue

1. Load any two layers; Let's say layer A is a point layer with an "ID" attribute (unique) and layer B is a CSV (with additional fields)
2. Open the attribute table of layer A.
3. On layer A, open "Layer Properties" > "Joins"
4. "Add a new join" and set "Join Layer" to layer B
5. Hit ok, Qgis becomes unresponsive.

Versions

QGIS version
3.24.1-Tisler
QGIS code revision
5709b82
Qt version
5.15.2
Python version
3.9.5
GDAL/OGR version
3.4.1
PROJ version
8.2.1
EPSG Registry database version
v10.041 (2021-12-03)
GEOS version
3.10.2-CAPI-1.16.0
SQLite version
3.37.2
PDAL version
2.3.0
PostgreSQL client version
unknown
SpatiaLite version
5.0.1
QWT version
6.1.3
QScintilla2 version
2.11.5
OS version
Windows 10 Version 2009

Active Python plugins
GeoCoding
2.18
go2streetview
8.1
QuickOSM
2.0.0
quick_map_services
0.19.19
realcentroid
1.0.3
searchlayers
3.0.2
StreetView
3.2
db_manager
0.1.20
grassprovider
2.12.99
MetaSearch
0.3.6
processing
2.12.99
sagaprovider
2.12.99

Supported QGIS version

• I'm running a supported QGIS version according to the roadmap.

New profile

• I tried with a new QGIS profile

Additional context

Works fine if the attribute table is closed. (Annoyingly layer properties/add join windows hold the focus so you can't easily close any attribute table you may have left open).
Have had this occur many times and doesn't appear to be restricted to any particular layer formats (I'm typically using shp, csv and/or geojson files).

[pigreco]

I confirm on QGIS 3.22.5, 3.24.1 and master

OSGeo4W64 v2 Win 10 Pro

[decheu]

same for me on QGIS 3.22.4 OSGeo4W install in Win10
also with clean default user profile
had this already several times in the past (I guess for years), never knew what caused the problem - thanks for reporting @Promethean-Roil !

[pigreco]

I found that this bug is also present in QGIS 3.16.16 but not in 3.16.0
Further testing is needed to understand in which version the bug was introduced.

EDIT:

• in QGIS 3.16.7 ok, no bug
• in QGIS 3.16.11 ok, no bug
• in QGIS 3.16.13 OK, no bug
• in QGIS 3.16.14 BUG!!! <--------------------------------------------------------------
• in QGIS 3.16.15 BUG!!!
• in QGIS 3.16.16 BUG!!!

[agiudiceandrea]

• in QGIS 3.16.13 OK, no bug
• in QGIS 3.16.14 BUG!!! <--------------------------------------------------------------

It seems there are only 10 commits between 3.16.13 and 3.16.14 https://github.com/qgis/QGIS/compare/final-3_16_13%E2%80%A6final-3_16_14 and no one, at first sight, seems related to this bug.

Is the Qt version (and other libraries) the same of both your installation of QGIS 3.16.13 and QGIS 3.16.14?

[pigreco]

@agiudiceandrea

in QGIS.3.20.3 Odense NO BUG !!!

EDIT:

in QGIS.3.21.0 DEV b46854adf6 NO BUG !!!

in QGIS.3.18.2 NO BUG !!!

[ludovico85]

• in QGIS 3.16.13 OK, no bug
• in QGIS 3.16.14 BUG!!! <--------------------------------------------------------------

It seems there are only 10 commits between 3.16.13 and 3.16.14 https://github.com/qgis/QGIS/compare/final-3_16_13%E2%80%A6final-3_16_14 and no one, at first sight, seems related to this bug.

Is the Qt version (and other libraries) the same of both your installation of QGIS 3.16.13 and QGIS 3.16.14?

I've made a test with 3.16.13 and 3.16.14.
QGIS 3.16.13 no bug

QGIS 3.16.14 with the bug

@pigreco

[rduivenvoorde]

I'd start to say that I think there is a lot of loud noise about this issue, both on Twitter, here and on the Mailing list. Why the drama? Is there an old issue (plz link to), or is this the first time?
About the "it's already open for 21 days": it's not always that easy to fix a seamingly easy to fix bug...

So please stay gentle and polite. Create a proper issue with some dataset here, and eventually ask for help on the mailing list?

But... I can confirm this on my Debian, version 3.25-master

Some small dataset to test, 12 records of shp and 12 lines of csv: join on provcode:

data.zip

QGIS hangs at:

src/gui/symbology/qgsrendererpropertiesdialog.cpp:63 : (_initRenderer) [0ms] Set for embeddedSymbol
src/gui/attributetable/qgsattributetablemodel.cpp:177 : (removeRows) [17556ms] remove 12 rows at 0 (rows 12, ids 12)

[rduivenvoorde]

Duh, thank @jef :-)