Added a working test case for parseNodes() #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jongillham @AlekSi, please review. Thanks! :) |
AlekSi
reviewed
Mar 12, 2018
decode_test.go
Outdated
| // Same file as above, but without 'DenseNodes'. This has been generated using the below command (using osmium-tool http://osmcode.org/osmium-tool/) | ||
| // "osmium cat -o greater-london-140324-nondense.osm.pbf greater-london-140324.osm.pbf -f osm.pbf,pbf_dense_nodes=false" | ||
| LondonNonDense = "greater-london-140324-nondense.osm.pbf" | ||
| LondonNonDenseURL = "https://gist.githubusercontent.com/clydedacruz/6263693f4facc28c84e768e708a489ff/raw/0f2ecad796a0234678c8fa6a0cc8fae376ead646/greater-london-140324-nondense.osm.pbf" |
There was a problem hiding this comment.
I just added it to the same gist as dense version: https://gist.github.com/AlekSi/d4369aa13cf1fc5ddfac3e91b67b2f7b. Please update that URL.
There was a problem hiding this comment.
@AlekSi I've updated the gist link
|
@AlekSi suggested updates are completed. Please review. Thanks! |
|
Merged (with small refactoring). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the existing GreaterLondon PBF file and generated a new PBF file that has nodes as
Nodesand notDenseNodes.Updated the test cases to include the test for 'non dense' nodes aswell.