-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made OSM header accessible #24
Merged
jongillham
merged 6 commits into
qedus:master
from
karsten42:feature/accessible-osm-header
Jun 22, 2017
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c3be37
added functionality to retrieve OSM header information from pbf file
653d89e
added functionality to retrieve OSM header information from pbf file
9c2131c
- using sync.Once to synchronize OSM header deserialization
51ecde2
- renamed OSM header 'Bbox' to 'BoundingBox'
624df92
renamed BBox to BoundingBox
dc52637
fixed error that led to errors in "readOsmHeader" function not being …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this may be simplified to the following without any worries about race conditions:
The
dec.header
pointer should always be passed to the calling function afterdec.readOSMHeader()
has been executed sodec.header
will be set unlessdec.readOSMHeader()
produces an error. The down side of my suggestion is that the race condition, or lack thereof, is less explicit.