-
Notifications
You must be signed in to change notification settings - Fork 1
Switch TopologySpreadConstraint.when_unsatisfiable to enum #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch TopologySpreadConstraint.when_unsatisfiable to enum #287
Conversation
This makes typing in the UI a lot easier and usage safer. We also do this for similar fields in Toleration.
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
This comment has been minimized.
This comment has been minimized.
|
PR Packages Published Python Package:
NPM Package:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the PR doesn't include updates for the generated code.
Please make sure you've run the following commands from the root directory:
make generateOnce you've added them, you can dismiss this review.
lomidzemikheili
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This makes typing in the UI a lot easier and usage safer. We also do this for similar fields in Toleration.