Skip to content

fix: replace condition to allow illegal timeout type usage #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

fix: replace condition to allow illegal timeout type usage #453

wants to merge 4 commits into from

Conversation

joein
Copy link
Member

@joein joein commented Jan 20, 2024

@netlify Netlify
Copy link

netlify bot commented Jan 20, 2024 •
edited
Loading

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit e16f7fd
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65ba58bda631910008542138
😎 Deploy Preview https://deploy-preview-453--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein marked this pull request as draft January 31, 2024 15:49
@joein
Copy link
Member Author

joein commented Jan 31, 2024

we would probably need to convert timeout to int in each operation if we want this feature to be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joein