Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs sticky sidebars #910

Closed
wants to merge 4 commits into from
Closed

Docs sticky sidebars #910

wants to merge 4 commits into from

Conversation

trean
Copy link
Collaborator

@trean trean commented May 17, 2024 •
edited
Loading

  • Sticky side menu and TOC on the docs page

@trean trean requested a review from generall May 17, 2024 11:38
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited
Loading

✅ Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit 4795f33
🔍 Latest deploy log https://app.netlify.com/sites/condescending-goldwasser-91acf0/deploys/6658875268cf450008315e0f
😎 Deploy Preview https://deploy-preview-910--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trean trean marked this pull request as ready for review May 17, 2024 11:58
generall
generall requested changes May 17, 2024
View reviewed changes
Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • scroll bar is always visible
  • left pannel can be bigger than screen and it is impossible to reach last items

@trean trean changed the base branch from new-design to master May 30, 2024 13:57
@trean
Copy link
Collaborator Author

trean commented Nov 14, 2024

Outdated and implemented in another place

@trean trean closed this Nov 14, 2024
@trean trean deleted the docs-sticky-sidebars branch November 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@generall generall generall requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trean @generall