VPNSP=custom for OpenVPN custom config files
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change: `up` and `down` options not filtered out - Change: `OPENVPN_INTERFACE` overrides the network interface of the file. - `VPNSP` value `custom` for OpenVPN only - Feat: config file is read when building the OpenVPN configuration, so it's effectively reloaded - Retro-compatibility: `OPENVPN_CUSTOM_CONFIG` set implies `VPNSP=custom` - Extract values from custom file to log out more valid settings - `PROTOCOL` has no effect - `PORT` overrides any port found in the configuration file - Maint: `internal/openvpn/extract` package instead of `internal/openvpn/custom` package - Maint: All providers' `BuildConf` method return an error - Maint: rename `CustomConfig` to `ConfFile`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #611
VPNSPvaluecustomfor OpenVPN onlyOPENVPN_CUSTOM_CONFIGset impliesVPNSP=customupanddownoptions are not filtered outOPENVPN_INTERFACEoverrides the network interface defined in the configuration filePORToverrides any port found in the configuration fileinternal/openvpn/extractpackage instead ofinternal/openvpn/custompackageBuildConfmethod return an errorCustomConfigtoConfFilein Settings structures