fix: Update mathematical notation for consistency in predefined.py #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://qctrl.atlassian.net/browse/PA-2317
This pull request includes several changes to the
qctrlopencontrols
library, specifically within thedriven_controls
anddynamic_decoupling_sequences
modules. The primary focus of these changes is to standardize the notation for the maximum Rabi frequency and improve the clarity of mathematical expressions.Standardization of notation:
\Omega_{\rm max}
to\Omega_{\mathrm max}
in thenew_primitive_control
,new_bb1_control
,new_sk1_control
,new_scrofulous_control
,new_corpse_control
,new_corpse_in_bb1_control
,new_corpse_in_sk1_control
,new_corpse_in_scrofulous_control
, andnew_wamf1_control
functions. [1] [2] [3] [4] [5] [6] [7] [8] [9]Improvement of mathematical expressions:
new_scrofulous_control
,new_corpse_control
,new_corpse_in_bb1_control
,new_corpse_in_sk1_control
, andnew_corpse_in_scrofulous_control
functions. [1] [2] [3] [4] [5]new_walsh_sequence
function to use\mathrm
for consistency.