Skip to content

build!: Drop support of 3.8 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2024
Merged

build!: Drop support of 3.8 #290

merged 5 commits into from
Feb 7, 2024

Conversation

tachikoma-li
Copy link
Member

As Python 3.8 is reaching EOL.

BREAKING CHANGE: Drop support of Python 3.8

@tachikoma-li tachikoma-li marked this pull request as ready for review February 6, 2024 03:35
@tachikoma-li tachikoma-li requested review from a team February 6, 2024 03:35
leoadec
leoadec previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@leoadec leoadec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Li!

abenseny
abenseny previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@kdav108
Copy link
Contributor

kdav108 commented Feb 6, 2024

There's a few places where we still mention/use python 3.8:

open-controls/.github/workflows/on-pull-request.yaml

Line 43 in 9898395

python: ["3.8", "3.9", "3.10", "3.11"]

open-controls/.pylintrc

Line 103 in 9898395

py-version=3.8

https://github.com/qctrl/open-controls/blob/98983957b450e9b3c1150a75dc66b24368c4986e/.github/README.md#requirements

@tachikoma-li tachikoma-li dismissed stale reviews from abenseny and leoadec via 309527e February 6, 2024 04:33
@tachikoma-li
Copy link
Member Author

open-controls/.github/workflows/on-pull-request.yaml

Line 43 in 9898395

python: ["3.8", "3.9", "3.10", "3.11"]

Removed.

open-controls/.pylintrc

Line 103 in 9898395

py-version=3.8

pylintrc is updated.

@tachikoma-li tachikoma-li requested a review from kdav108 February 6, 2024 04:36
ThomasMerkh
ThomasMerkh approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@ThomasMerkh ThomasMerkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kdav108
kdav108 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@kdav108 kdav108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tachikoma-li tachikoma-li merged commit 6de0dcb into master Feb 7, 2024
@tachikoma-li tachikoma-li deleted the drop3.8 branch February 7, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasMerkh ThomasMerkh ThomasMerkh approved these changes

@abenseny abenseny abenseny left review comments

@leoadec leoadec leoadec left review comments

+1 more reviewer

@kdav108 kdav108 kdav108 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tachikoma-li @kdav108 @abenseny @leoadec @ThomasMerkh