Skip to content

Conversation

tachikoma-li
Copy link
Member

@tachikoma-li tachikoma-li commented Nov 3, 2022

This simplifies the dependencies, and also allows us to support python 3.11 later.

Add a comment about installing qctrl-visualizer. Note that since visualizer was a dev-dependency, users need to install it first anyway.

@tachikoma-li tachikoma-li marked this pull request as ready for review November 3, 2022 22:13
@tachikoma-li tachikoma-li requested a review from a team November 3, 2022 22:13
abenseny
abenseny previously approved these changes Nov 3, 2022
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Li!
I've left an optional nit.

Co-authored-by: ABC <16929811+abenseny@users.noreply.github.com>
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tachikoma-li tachikoma-li merged commit 9af53c5 into master Nov 3, 2022
@tachikoma-li tachikoma-li deleted the remove-visualizer branch November 3, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants