add zapi::lang::Variant::get method

qcoreteam · Jun 9, 2017 · f7d96a0 · f7d96a0
1 parent b309317
commit f7d96a0
Show file tree

Hide file tree

Showing 3 changed files with 760 additions and 4 deletions.
diff --git a/include/zapi/lang/Type.h b/include/zapi/lang/Type.h
@@ -43,7 +43,7 @@ enum class Type : unsigned char
    Constant    = IS_CONSTANT, // A constant value
    ConstantAST = IS_CONSTANT_AST, // I think an Abstract Syntax tree, not quite sure
    // "fake types", not quite sure what that means
-   Bool        = _IS_BOOL, // You will never get this back as a type
+   Boolean     = _IS_BOOL, // You will never get this back as a type
    Callable    = IS_CALLABLE, // I don't know why this is a "fake" type
    // internal types
    Indirect    = IS_INDIRECT,

diff --git a/include/zapi/lang/Variant.h b/include/zapi/lang/Variant.h
@@ -685,7 +685,7 @@ class ZAPI_DECL_EXPORT Variant
     * @param  size
     * @return Value
     */
-   Variant get(const char *key, int size = -1) const;
+   Variant get(const char *key, ssize_t size = -1) const;
 
    /**
     * Set a certain property
@@ -986,7 +986,7 @@ class ZAPI_DECL_EXPORT Variant
     * @param  allowString Allow the 'this' object to be a string
     * @return zend_class_entry
     */
-   _zend_class_entry *classEntry(bool allowString = true) const;
+   _zend_class_entry *getClassEntry(bool allowString = true) const;
 
 protected:
    Zval m_val;