improve the XML generation: prolog optional, using [] instead of :empty #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcam
reviewed
Mar 19, 2020
|
@qcam do you know why 1.8 is failing? I was creating the same docker image and running exactly the same steps and it's working for me :-/ |
|
now worked! :-) ... @qcam I checked you have no |
|
Thanks, I will remove the Travis config file in another commit. |
qcam
approved these changes
Mar 19, 2020
|
@manuel-rubio Thank you ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just needed to use it without the prolog (
<?xml ... ?>) generation and I realised that instead of:emptywe could use[](which means empty list indeed). I want to use it in this way because of optimization in generation of the XML and avoid to use prolog to employ it in an XMPP dialogue.